Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylint recognizes cirq_google as known third_party #4071

Merged
merged 2 commits into from
Apr 29, 2021
Merged

pylint recognizes cirq_google as known third_party #4071

merged 2 commits into from
Apr 29, 2021

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Apr 29, 2021

Fixes three things:

  • check/pylint was pointing to the wrong folders (platform -> cirq-google/cirq_google)
  • pylint (and the underlying isort) needs to know about cirq_google and cirq as not third_party libraries for import sorting to work properly
  • there was an unused import in cirq_google that is now removed

@balopat balopat requested review from cduck, vtomole and a team as code owners April 29, 2021 18:40
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Apr 29, 2021
mpharrigan
mpharrigan approved these changes Apr 29, 2021
View reviewed changes
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 29, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 29, 2021
@CirqBot CirqBot merged commit dd36446 into quantumlib:master Apr 29, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 29, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@balopat @rht
pylint recognizes cirq_google as known third_party (quantumlib#4071)
f5811ac 
Fixes three things: 

* check/pylint was pointing to the wrong folders (platform -> cirq-google/cirq_google)
* pylint (and the underlying isort) needs to know about cirq_google and cirq as not third_party libraries for import sorting to work properly
* there was an unused import in cirq_google that is now removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balopat @mpharrigan @CirqBot