Move CliffordTableau and add unit test #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
reviewed
May 4, 2021
balopat
reviewed
May 4, 2021
balopat
suggested changes
May 4, 2021
|
Thanks. Added the assert_deprecated. PTAL. |
balopat
approved these changes
May 5, 2021
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Fix quantumlib#4075. To avoid breakage, the original `cirq/sim/clifford/CliffordTableau` is untouched added with deprecated notation. All internal import of Cliffod Tableau is pointed to the new position under `cirq/qis`. (Unless people have strong opinions of putting it into other places.) New clifford_tableau is the same as the old one except in one place -- the `xs`, `zs`, and `rs` are protected by getter and setter pattern and do not expose the last scratch row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4075.
To avoid breakage, the original
cirq/sim/clifford/CliffordTableauis untouched added with deprecated notation.All internal import of Cliffod Tableau is pointed to the new position under
cirq/qis. (Unless people have strong opinions of putting it into other places.)New clifford_tableau is the same as the old one except in one place -- the
xs,zs, andrsare protected by getter and setter pattern and do not expose the last scratch row.