-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump cirq to v0.12.0.dev #4121
bump cirq to v0.12.0.dev #4121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note that changes merged since the 0.11.0 release have been getting pushed to pypi as pre-release versions and show up in the version history as earlier than the 0.11.0 release: https://pypi.org/project/cirq/#history. We might want to detect this kind of scenario when we attempt to publish to pypi by looking at tags in the git history (if there's a vA.B.C
tag in the history, then fail if you try to publish a pre-release vA.B.C.dev
). Instead (or in addition), we could add more automation around the release process by having a script that generates the version bump commit so we don't forget to do it.
Agreed that we should put in automation around the release process and potentially more checks and balances. It is especially going to be important in this monorepo world. |
I forgot to do this at the release of v0.11.
I forgot to do this at the release of v0.11.
I forgot to do this at the release of v0.11.