Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cirq to v0.12.0.dev #4121

Merged
merged 2 commits into from
May 20, 2021
Merged

bump cirq to v0.12.0.dev #4121

merged 2 commits into from
May 20, 2021

Conversation

balopat
Copy link
Contributor

@balopat balopat commented May 19, 2021

I forgot to do this at the release of v0.11.

@balopat balopat requested review from cduck, vtomole and a team as code owners May 19, 2021 23:31
@balopat balopat requested a review from tanujkhattar May 19, 2021 23:31
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label May 19, 2021
Copy link
Contributor

@maffoo maffoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that changes merged since the 0.11.0 release have been getting pushed to pypi as pre-release versions and show up in the version history as earlier than the 0.11.0 release: https://pypi.org/project/cirq/#history. We might want to detect this kind of scenario when we attempt to publish to pypi by looking at tags in the git history (if there's a vA.B.C tag in the history, then fail if you try to publish a pre-release vA.B.C.dev). Instead (or in addition), we could add more automation around the release process by having a script that generates the version bump commit so we don't forget to do it.

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 20, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 20, 2021
@CirqBot CirqBot merged commit edbee2c into quantumlib:master May 20, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels May 20, 2021
@balopat
Copy link
Contributor Author

balopat commented May 20, 2021

LGTM

Note that changes merged since the 0.11.0 release have been getting pushed to pypi as pre-release versions and show up in the version history as earlier than the 0.11.0 release: https://pypi.org/project/cirq/#history. We might want to detect this kind of scenario when we attempt to publish to pypi by looking at tags in the git history (if there's a vA.B.C tag in the history, then fail if you try to publish a pre-release vA.B.C.dev). Instead (or in addition), we could add more automation around the release process by having a script that generates the version bump commit so we don't forget to do it.

Agreed that we should put in automation around the release process and potentially more checks and balances. It is especially going to be important in this monorepo world.

@balopat balopat mentioned this pull request May 24, 2021
NoureldinYosri pushed a commit to NoureldinYosri/Cirq that referenced this pull request May 25, 2021
I forgot to do this at the release of v0.11.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
I forgot to do this at the release of v0.11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants