Consolidate dependencies #4131
Merged
Consolidate dependencies #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
changed the title
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Moves all dependency logic to requirements.txt file composition rules. Setting up your local env now is just a single line: `pip install -r dev_tools/requirements/dev.env.txt` Each job in CI is referring to a single pip requirements file ,e.g. `dev_tools/requirements/mypy.env.txt` - which in turn includes -`./deps/cirq-all.txt` and `./deps/mypy.txt`. `dev_tools/requirements/deps/cirq-all.txt` is a single place to define all the dependencies for all cirq modules. This will mainly help with the issues listed in quantumlib#3996 as - it centralizes the list of cirq modules in a single place, - removes the 'cat req.txt | grep pytest | xargs pip install` type of instructions that are error-prone and slow (separate calls to pip install vs a single call for all the requirements) All in all, it will help with making our scripts more scalable as more modules are extracted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all dependency logic to requirements.txt file composition rules.
Setting up your local env now is just a single line:
pip install -r dev_tools/requirements/dev.env.txtEach job in CI is referring to a single pip requirements file ,e.g.
dev_tools/requirements/mypy.env.txt- which in turn includes -./deps/cirq-all.txtand./deps/mypy.txt.dev_tools/requirements/deps/cirq-all.txtis a single place to define all the dependencies for all cirq modules.This will mainly help with the issues listed in #3996 as
All in all, it will help with making our scripts more scalable as more modules are extracted.