Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pathname in misc check tool #4133

Merged
merged 1 commit into from
May 26, 2021
Merged

Fix pathname in misc check tool #4133

merged 1 commit into from
May 26, 2021

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented May 26, 2021

Fixes an error message from grep. Before:

$ ./check/all
Running misc
grep: cirq: No such file or directory
No issues.
Running pylint
...

After:

$ ./check/all
Running misc
No issues.
Running pylint
...

@viathor viathor requested review from cduck, vtomole and a team as code owners May 26, 2021 00:54
@viathor viathor requested a review from tanujkhattar May 26, 2021 00:54
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label May 26, 2021
vtomole
vtomole approved these changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viathor viathor merged commit 6c72b5b into quantumlib:master May 26, 2021
@viathor viathor deleted the path-fix-in-misc-check branch May 26, 2021 03:29
vtomole
vtomole reviewed May 26, 2021
View reviewed changes
check/misc Show resolved Hide resolved
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@viathor @rht
Fix pathname in misc check tool (quantumlib#4133)
297be9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@viathor @vtomole