Fix the typo in clifford_gate_test::test_commutes_pauli #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
approved these changes
Jun 4, 2021
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
) Although the original test is still theoretically correct, it doesn't make sense to make the expected result with an exponent but call the actual `commutes` function without an exponent. And I guess 0.1 was a typo for 1.0. There was another error revealed when I tried to fix it -- `cirq.allclose_up_to_global_phase(mat, mat_swap)`. "Up to gloabl phase" means both commutive and anti-commutive operators return ture, which is not desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the original test is still theoretically correct, it doesn't make sense to make the expected result with an exponent but call the actual
commutesfunction without an exponent. And I guess 0.1 was a typo for 1.0.There was another error revealed when I tried to fix it --
cirq.allclose_up_to_global_phase(mat, mat_swap). "Up to gloabl phase" means both commutive and anti-commutive operators return ture, which is not desired.