Update Google Best Practices #4168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include more information on qubit picking and characterization. - Link to new tutorials on XEB and Floquet.
dstrain115
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
balopat
approved these changes
Jun 8, 2021
docs/google/best_practices.md
Outdated
| calibration procedure. These metrics can be used as a baseline to evaluate | ||
| circuit performance or identify outliers to avoid. This data can be inspected | ||
| programmatically by retrieving metrics from the [API](calibration.md) or | ||
| visually by applying a `cirq.Heatmap` to that data or by using the built-in |
There was a problem hiding this comment.
link to the visualizaing metrics tutorial: https://quantumai.google/cirq/tutorials/google/visualizing_calibration_metrics
docs/google/best_practices.md
Outdated
| be parameterized into 5 angles, or degrees of freedom. Characterization will | ||
| attempt to identify the values of these five angles. | ||
|
|
||
| The second step is calibrating (or refitting) the gate. For the five angles |
There was a problem hiding this comment.
Suggested change
| The second step is calibrating (or refitting) the gate. For the five angles | |
| The second step is *calibrating* (or refitting) the gate. For the five angles |
Just to match formatting with characerization above.
balopat
reviewed
Jun 8, 2021
| The second step is calibrating (or refitting) the gate. For the five angles | ||
| that comprise the generalized FSim gate, three can be corrected for by adding | ||
| Z rotations before or after the gate. Since these gates are propagated forward | ||
| automatically, they add no duration or error to the circuit and can essentially |
There was a problem hiding this comment.
I think we could be a bit more precise what we mean by "propagated forward automatically". Also maybe we can mention that these are partial Z phases...if I understand correctly - or are these full Z gates?
There was a problem hiding this comment.
Linked to device page, and also updated that page with more information, since it has been a source of quite some confusion.
There was a problem hiding this comment.
Did you push this change? I don't see the update neither here nor in the other page.
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
…Cirq-1 into update_best_practics
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Update Google Best Practices - Include more information on qubit picking and characterization. - Link to new tutorials on XEB and Floquet. - Include more information on virtual Z gates Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
characterization.