Add Clifford Tableau decomposition function #4183

bichengying · 2021-06-10T04:30:43Z

Decompose clifford tableau into one/two qubits operations (X, Z, S, H, CNOT, and SWAP). The method is based on Aaronson & Gottesman's paper [WIP for #3639].

Issue #4182 is discovered in this PR's test.

This reverts commit b2d9269.

cirq-core/cirq/optimizers/clifford_decomposition.py

cirq-core/cirq/ops/common_gates.py

cirq-core/cirq/optimizers/clifford_decomposition.py

balopat · 2021-06-15T00:25:34Z

cirq-core/cirq/optimizers/clifford_decomposition_test.py

+    assert_allclose_up_to_global_phase(cirq.unitary(expect_circ), cirq.unitary(circ), atol=1e-7)
+
+
+def test_clifford_decompose_by_unitary():


I'm wondering if we can reuse the implementation of assert_implements_consistent_protocols in cirq.testing.consistent_protocols? It does have a decomposition consistent with unitary assertion...

After a brief look of this function, I think it is more suitable to put into the n_qubit_clifford_gate class, which is the next step when all these Clifford Tableau helper functions are done. Wdyt?

I guess that can work - and will be consistent with having Gates having a decomposition - but on the other hand there is nothing wrong with having it on the tableau and then the Gate delegating to the tableau's method, so I think I'm okay to have it here, as this way the Aaaronson-Gottesman paper implementations are kept closer together.

cirq-core/cirq/optimizers/clifford_decomposition.py

Co-authored-by: Balint Pato <balopat@users.noreply.github.com>

google-cla · 2021-09-29T03:13:48Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

MichaelBroughton

LGTM. @Strilanc for visibility.

cirq-core/cirq/optimizers/clifford_decomposition.py

google-cla · 2021-10-01T03:05:20Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-10-01T18:11:42Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

CirqBot · 2021-10-01T18:11:52Z

Automerge cancelled: A status check is failing.

@daxfohl

Add initial Clifford Gate with multiple qubits. Compared with SingleQubitCliffordGate, it has fewer functionalities since we cannot enumerate all of them with PauliGates and several special single qubit properties like Bloch rotation no longer exist. Anyway, it provides several basic interactions: 1. It uses Clifford tableau as underlying data representation (different from the state representation). 2. It can be constructed from a tableau or list of operations (`_has_stabilizer_effect_` only). All Clifford gates can be built through \{S, H, CNOT\}, so we can construct any Clifford Gate from the list of operations. We just cannot pre-define it. 3. Decomposing into several basic operations. 4. Get unitary matrix through decomposing (we cannot do this in a reverse way from unitary to Clifford gate :( ). 5. Know how to interact with ActOnCliffordTableauArgs, i.e. it should be able to use with CliffordTableau simulator (Looks like we don't have that in cirq yet? @daxfohl will add that? see #4639 and #4748.). This PR is part of efforts for #3639. Context: this PR doesn't introduce any new algorithms but the key methods are already implemented in #4183 and #4096.

@daxfohl

Add initial Clifford Gate with multiple qubits. Compared with SingleQubitCliffordGate, it has fewer functionalities since we cannot enumerate all of them with PauliGates and several special single qubit properties like Bloch rotation no longer exist. Anyway, it provides several basic interactions: 1. It uses Clifford tableau as underlying data representation (different from the state representation). 2. It can be constructed from a tableau or list of operations (`_has_stabilizer_effect_` only). All Clifford gates can be built through \{S, H, CNOT\}, so we can construct any Clifford Gate from the list of operations. We just cannot pre-define it. 3. Decomposing into several basic operations. 4. Get unitary matrix through decomposing (we cannot do this in a reverse way from unitary to Clifford gate :( ). 5. Know how to interact with ActOnCliffordTableauArgs, i.e. it should be able to use with CliffordTableau simulator (Looks like we don't have that in cirq yet? @daxfohl will add that? see quantumlib#4639 and quantumlib#4748.). This PR is part of efforts for quantumlib#3639. Context: this PR doesn't introduce any new algorithms but the key methods are already implemented in quantumlib#4183 and quantumlib#4096.

Decompose clifford tableau into one/two qubits operations (X, Z, S, H, CNOT, and SWAP). The method is based on [Aaronson & Gottesman's paper](https://arxiv.org/abs/quant-ph/0406196) [WIP for quantumlib#3639]. Issue quantumlib#4182 is discovered in this PR's test.

@daxfohl

Add initial Clifford Gate with multiple qubits. Compared with SingleQubitCliffordGate, it has fewer functionalities since we cannot enumerate all of them with PauliGates and several special single qubit properties like Bloch rotation no longer exist. Anyway, it provides several basic interactions: 1. It uses Clifford tableau as underlying data representation (different from the state representation). 2. It can be constructed from a tableau or list of operations (`_has_stabilizer_effect_` only). All Clifford gates can be built through \{S, H, CNOT\}, so we can construct any Clifford Gate from the list of operations. We just cannot pre-define it. 3. Decomposing into several basic operations. 4. Get unitary matrix through decomposing (we cannot do this in a reverse way from unitary to Clifford gate :( ). 5. Know how to interact with ActOnCliffordTableauArgs, i.e. it should be able to use with CliffordTableau simulator (Looks like we don't have that in cirq yet? @daxfohl will add that? see quantumlib#4639 and quantumlib#4748.). This PR is part of efforts for quantumlib#3639. Context: this PR doesn't introduce any new algorithms but the key methods are already implemented in quantumlib#4183 and quantumlib#4096.

bichengying added 7 commits May 28, 2021 23:29

Fix the typo in clifford_gate::test_commutes_pauli

b2d9269

Revert "Fix the typo in clifford_gate::test_commutes_pauli"

0234dda

This reverts commit b2d9269.

Merge remote-tracking branch 'upstream/master' into master

7596136

Initial Clifford Decomposition Method

03dc632

Update the test of Clifford decomposition

b5cffae

Change to ActOnCliffordTableauArgs style

b7b7170

Fix some typos

20760c2

google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 10, 2021

bichengying added 2 commits June 9, 2021 22:20

Add misaligned_qubits test

4ede0af

fix the lint

a076caa

bichengying marked this pull request as ready for review June 10, 2021 05:37

bichengying requested review from cduck, vtomole and a team as code owners June 10, 2021 05:37

bichengying requested a review from dstrain115 June 10, 2021 05:37

bichengying mentioned this pull request Jun 11, 2021

Fix the CZ ops on the Clifford Tableau Implementation #4182

Merged

balopat suggested changes Jun 15, 2021

View reviewed changes

bichengying and others added 6 commits June 15, 2021 21:47

Update cirq-core/cirq/optimizers/clifford_decomposition.py

1a2ef9b

Co-authored-by: Balint Pato <balopat@users.noreply.github.com>

Update cirq-core/cirq/optimizers/clifford_decomposition.py

9f87a05

Co-authored-by: Balint Pato <balopat@users.noreply.github.com>

Update cirq-core/cirq/optimizers/clifford_decomposition.py

56a536e

Co-authored-by: Balint Pato <balopat@users.noreply.github.com>

Update cirq-core/cirq/optimizers/clifford_decomposition.py

31a30bf

Co-authored-by: Balint Pato <balopat@users.noreply.github.com>

Update cirq-core/cirq/optimizers/clifford_decomposition.py

a5bf003

Co-authored-by: Balint Pato <balopat@users.noreply.github.com>

Add type annotation

6c2a9a3

bichengying requested a review from balopat June 16, 2021 05:06

bichengying added 4 commits June 20, 2021 12:01

Merge remote-tracking branch 'upstream/master' into master

3121748

Merge remote-tracking branch 'upstream/master' into master

566db2f

Merge branch 'master' into decompose_clifford

9d0dbd1

Update the act_on for new style

ad20805

balopat self-assigned this Jul 1, 2021

Merge branch 'master' into decompose_clifford

ea0af8e

Fix lint error about documenting the raise.

db940ed

google-cla bot added cla: no and removed cla: yes Makes googlebot stop complaining. labels Sep 29, 2021

MichaelBroughton approved these changes Sep 30, 2021

View reviewed changes

cirq-core/cirq/optimizers/clifford_decomposition.py Outdated Show resolved Hide resolved

cirq-core/cirq/optimizers/clifford_decomposition.py Show resolved Hide resolved

Add paper link to docstring and fix a typo

67147e3

MichaelBroughton added cla: yes Makes googlebot stop complaining. automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed cla: no labels Oct 1, 2021

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 1, 2021

Merge branch 'master' into decompose_clifford

9f7ce6d

google-cla bot added cla: no and removed cla: yes Makes googlebot stop complaining. labels Oct 1, 2021

CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 1, 2021

MichaelBroughton added cla: yes Makes googlebot stop complaining. automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed cla: no labels Oct 1, 2021

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 1, 2021

CirqBot merged commit 9d0ac9c into quantumlib:master Oct 1, 2021

CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 1, 2021

bichengying mentioned this pull request Jan 2, 2022

Multiple Qubits Clifford Gate #4791

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Clifford Tableau decomposition function #4183

Add Clifford Tableau decomposition function #4183

bichengying commented Jun 10, 2021 •

edited

balopat Jun 15, 2021

bichengying Jun 16, 2021

balopat Jun 17, 2021

google-cla bot commented Sep 29, 2021

MichaelBroughton left a comment

google-cla bot commented Oct 1, 2021

google-cla bot commented Oct 1, 2021

CirqBot commented Oct 1, 2021

		assert_allclose_up_to_global_phase(cirq.unitary(expect_circ), cirq.unitary(circ), atol=1e-7)


		def test_clifford_decompose_by_unitary():

Add Clifford Tableau decomposition function #4183

Add Clifford Tableau decomposition function #4183

Conversation

bichengying commented Jun 10, 2021 • edited

balopat Jun 15, 2021

Choose a reason for hiding this comment

bichengying Jun 16, 2021

Choose a reason for hiding this comment

balopat Jun 17, 2021

Choose a reason for hiding this comment

google-cla bot commented Sep 29, 2021

MichaelBroughton left a comment

Choose a reason for hiding this comment

google-cla bot commented Oct 1, 2021

google-cla bot commented Oct 1, 2021

CirqBot commented Oct 1, 2021

bichengying commented Jun 10, 2021 •

edited