Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two-qubit interaction heatmap to parallel xeb tutorial #4199

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

rmlarose
Copy link
Contributor

Closes #3932.

@rmlarose rmlarose requested review from cduck, mrwojtek, vtomole and a team as code owners June 14, 2021 06:38
@rmlarose rmlarose requested a review from viathor June 14, 2021 06:38
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 14, 2021
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed it, looks good!

image

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 14, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 14, 2021
@CirqBot CirqBot merged commit e151a66 into quantumlib:master Jun 14, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 14, 2021
@@ -303,7 +303,23 @@
"outputs": [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be rewritten in slightly more concise way (which makes heatmap_data immutable which is a good property):

heatmap_data = {

pair: 1.0 - fidelity for (_, _, pair), fidelity in fidelities.layer_fid.items()

}


Reply via ReviewNB

Copy link
Collaborator

@mrwojtek mrwojtek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks also good for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add heatmap visualization to parallel XEB tutorial
4 participants