Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4173] Add atol/rtol for unitary checks in MatrixGate #4220

Merged
merged 11 commits into from
Jun 21, 2021

Conversation

shivanth
Copy link
Contributor

@shivanth shivanth commented Jun 17, 2021

Add rtol/atol for unitary checks in MatrixGate.

Fixes #4173.

@shivanth shivanth requested review from cduck, vtomole and a team as code owners June 17, 2021 15:35
@shivanth shivanth requested a review from mpharrigan June 17, 2021 15:35
@google-cla
Copy link

google-cla bot commented Jun 17, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 17, 2021
@shivanth
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Makes googlebot stop complaining. and removed cla: no labels Jun 17, 2021
@shivanth shivanth changed the title [4173] Add aotl/rotl for unitary checks in matrixGate [4173] Add atol/rtol for unitary checks in matrixGate Jun 17, 2021
@balopat balopat changed the title [4173] Add atol/rtol for unitary checks in matrixGate [4173] Add atol/rtol for unitary checks in MatrixGate Jun 17, 2021
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this! Can you please add unit tests for the new parameters?

@balopat
Copy link
Contributor

balopat commented Jun 18, 2021

Looks good, please run check/format-incremental --apply

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 21, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 21, 2021
@CirqBot CirqBot merged commit 7d9e603 into quantumlib:master Jun 21, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 21, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow MatrixGate to be less strict w.r.t. unitarity
3 participants