-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No DeprecationWarning deduping during testing #4239
Merged
CirqBot
merged 15 commits into
quantumlib:master
from
balopat:fix_deprecation_logic_json_tests
Jun 25, 2021
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7bbec59
disable deprecation warning deduping during testing and fix deprecati…
balopat 2517f4d
typo
balopat 4a4f795
Merge branch 'master' into fix_deprecation_logic_json_tests
balopat 28e4f8c
mypy
balopat 12003e2
add flynt for pytest minimal
balopat 3d5a1f5
add flynt for pytest minimal
balopat 21b3c4c
Merge branch 'fix_flynt_for_changed_files' into fix_deprecation_logic…
balopat 60ed090
Merge branch 'master' into fix_deprecation_logic_json_tests
tanujkhattar 9c3ae10
Merge branch 'master' into fix_deprecation_logic_json_tests
balopat a642000
added conftest.py for each module to turn on CIRQ_TESTING
balopat bf749a8
Merge branch 'fix_deprecation_logic_json_tests' of github.com:balopat…
balopat 8a78c25
fix coverage
balopat 885c9b8
review comments
balopat 3663e07
Merge branch 'master' into fix_deprecation_logic_json_tests
balopat 0b56ad8
Merge branch 'master' into fix_deprecation_logic_json_tests
balopat File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import os | ||
|
||
|
||
def pytest_configure(config): | ||
os.environ['CIRQ_TESTING'] = "true" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the default iterator instead of calling
.keys()
on the dictionary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? I'm not using the dictionary part...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using default iterators, whenever supported, is more generic and avoids an unnecessary function call.
https://google.github.io/styleguide/pyguide.html#28-default-iterators-and-operators