Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes direct URL requirements from cirq[dev-env] #4249

Merged
merged 3 commits into from Jun 22, 2021
Merged

Removes direct URL requirements from cirq[dev-env] #4249

merged 3 commits into from Jun 22, 2021

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jun 21, 2021

Removes direct URL requirements from cirq[dev-env].

Fixes #4222.
This is hard to test automatically as it would need to involve uploading to test pypi which in turn requires secrets on Github Actions (see #4247).

@balopat balopat requested review from cduck, vtomole and a team as code owners June 21, 2021 22:05
@balopat balopat requested a review from dstrain115 June 21, 2021 22:05
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 21, 2021
@balopat balopat requested a review from Strilanc June 22, 2021 01:15
@balopat balopat mentioned this pull request Jun 22, 2021
Closed
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 22, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 22, 2021
@CirqBot CirqBot merged commit d7a5b9b into quantumlib:master Jun 22, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 22, 2021
@mpharrigan
Copy link
Collaborator

#4252 implied we wouldn't want an inconsistency between the requirements file and the [dev-env] pip thing. Did we decide this isn't an issue?

@balopat
Copy link
Contributor Author

balopat commented Jun 22, 2021 •
edited

#4252 implied we wouldn't want an inconsistency between the requirements file and the [dev-env] pip thing. Did we decide this isn't an issue?

I'm fine either way - the current approach still gives a dev-env without needing to install cirq, purely from pypi, which is kind of cool, even though it misses tensorflow-docs.

The other approach kills an (assumedly) rarely used feature...

In the internal chat Craig decided to approve the former.

rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@balopat @rht
Removes direct URL requirements from cirq[dev-env] (quantumlib#4249)
6662ac3 
Removes direct URL requirements from cirq[dev-env].

Fixes quantumlib#4222.
This is hard to test automatically as it would need to involve uploading to test pypi which in turn requires secrets on Github Actions (see quantumlib#4247).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strilanc Strilanc Strilanc approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@dstrain115 dstrain115 Awaiting requested review from dstrain115

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push to PyPi failing
4 participants
@balopat @mpharrigan @Strilanc @CirqBot