Revert "Support qubits in MeasurementKey and update JSON serialization of keys"
#4277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
approved these changes
Jun 30, 2021
Strilanc
approved these changes
Jun 30, 2021
smitsanghavi
approved these changes
Jun 30, 2021
Done: added |
vtomole
requested changes
Jun 30, 2021
| gate=cirq.MeasurementGate(1, cirq.MeasurementKey(path=(), name='q0_1_0'), ()), | ||
| qubits=[cirq.GridQubit(0, 1)], | ||
| ) | ||
| assert op == eval(repr(op)) |
There was a problem hiding this comment.
cirq.testing.assert_equivalent_repr won't work here?
There was a problem hiding this comment.
Good point - updated to use that instead.
There was a problem hiding this comment.
@vtomole, PTAL - merge is blocked on your review.
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: Merging is blocked (I don't understand why). |
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…ion of keys" (quantumlib#4277) * Revert "Support qubits in `MeasurementKey` and update JSON serialization of keys (quantumlib#4123)" This reverts commit 81436fe. * Safeguard against repr-inequality. * assert_equivalent_repr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4123 due to issues uncovered in #4273.