[XEB] Cycle depths during analysis #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mpharrigan
commented
Jun 30, 2021
mpharrigan
commented
- Make the argument optional in benchmark_
- If provided, you can do a subset of those in sampled_df
- More robust checking that it matches sampled_df
- Make optional - If provided, you can do a subset of those in sampled_df - More robust checking that it matches sampled_df
mpharrigan
requested review from
cduck,
mrwojtek,
vtomole and
a team
as code owners
mrwojtek
approved these changes
Jul 2, 2021
| if len(cycle_depths) == 0: | ||
| raise ValueError("`cycle_depths` should be a non-empty array_like") | ||
| not_in_sampled = np.setdiff1d(cycle_depths, sampled_cycle_depths) | ||
| if len(not_in_sampled) > 0: |
There was a problem hiding this comment.
I know some style guides disagree, but I think in Cirq and me personally we usually are explicit. I think it reads closer to the intent
| f"The `cycle_depths` provided include some not " | ||
| f"available in `sampled_df`: {not_in_sampled}" | ||
| ) | ||
| sim_cycle_depths = np.intersect1d(cycle_depths, sampled_cycle_depths) |
There was a problem hiding this comment.
Isn't the interesect1d redundant here? sampled_cycle_depths is always a superset of cycle_depths because of the previous condition, and result is always cycle_depths?
There was a problem hiding this comment.
yes that's true. removed
mpharrigan
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Changed files test', 'Doc test'] |
CirqBot
removed
automerge
mpharrigan
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Changed files test', 'Doc test'] |
CirqBot
removed
automerge
|
Beep boop |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- Make the argument optional in benchmark_ - If provided, you can do a subset of those in sampled_df - More robust checking that it matches sampled_df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.