Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use partial_trace to factor density matrix #4300

Merged
merged 3 commits into from Jul 8, 2021
Merged

Use partial_trace to factor density matrix #4300

merged 3 commits into from Jul 8, 2021

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Jul 8, 2021

Fixes #4292

@daxfohl daxfohl requested review from cduck, vtomole and a team as code owners July 8, 2021 16:42
@daxfohl daxfohl requested a review from mpharrigan July 8, 2021 16:42
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jul 8, 2021
@daxfohl
Copy link
Contributor Author

daxfohl commented Jul 8, 2021

@95-martin-orion ptal

@95-martin-orion 95-martin-orion self-requested a review July 8, 2021 16:55
@95-martin-orion 95-martin-orion self-assigned this Jul 8, 2021
95-martin-orion
95-martin-orion approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and to the point. LGTM

@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 8, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 8, 2021
@CirqBot
Copy link
Collaborator

CirqBot commented Jul 8, 2021

Automerge cancelled: A required status check is not present.

Missing statuses: ['Type check']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 8, 2021
@95-martin-orion 95-martin-orion merged commit e2b4477 into quantumlib:master Jul 8, 2021
@daxfohl daxfohl deleted the dmfix branch July 9, 2021 04:22
@daxfohl daxfohl mentioned this pull request Oct 12, 2022
Open
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @CirqBot @rht
Use partial_trace to factor density matrix (quantumlib#4300)
a6caba6 
* Use `partial_trace` to factor density matrix

* format

Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@mpharrigan mpharrigan Awaiting requested review from mpharrigan

Assignees

@95-martin-orion 95-martin-orion

Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Density matrix factoring incorrect
3 participants
@daxfohl @CirqBot @95-martin-orion