Return self in Operation.with_tags if adding no tags #4301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny optimization that came up for me when trying to "copy" an operation with modifications. I want to be able to unconditionally add tags from the original operation but have it only create a
TaggedOperation
if needed, so I moved the logic to check whether the tags tuple is empty inside thewith_tags
method.Also note that in most cases one does not have to check whether something
isinstance(..., cirq.TaggedOperation)
, because we can access the.tags
field unconditionally and it will simply be empty for untagged ops. Simplified theis_virtual_moment
method in noise model to take advantage of this.