Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NameError in visualizing calibration metrics tutorial #4316

Merged
merged 2 commits into from Jul 14, 2021

Conversation

rmlarose
Copy link
Contributor

cirq_google is used to get calibrations in line 181 but never imported, leading to NameError: name cirq_google is not defined (189945709).

@rmlarose rmlarose requested review from cduck, vtomole, wcourtney and a team as code owners July 13, 2021 01:50
@rmlarose rmlarose requested a review from viathor July 13, 2021 01:50
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jul 13, 2021
@viathor viathor self-assigned this Jul 13, 2021
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 14, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 14, 2021
@CirqBot CirqBot merged commit d9e1f93 into quantumlib:master Jul 14, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 14, 2021
@rmlarose rmlarose deleted the fix-cirq-google-import-vis-cal branch July 14, 2021 19:46
erichulburd pushed a commit to erichulburd/Cirq that referenced this pull request Jul 15, 2021
…ib#4316)

`cirq_google` is used to get calibrations in line 181 but never imported, leading to `NameError: name cirq_google is not defined` (189945709).
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…ib#4316)

`cirq_google` is used to get calibrations in line 181 but never imported, leading to `NameError: name cirq_google is not defined` (189945709).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants