Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing quote in circuits.ipynb #4320

Merged
merged 8 commits into from Jul 14, 2021

Conversation

LaurentAjdnik
Copy link
Contributor

Adds a missing quote in the Circuits notebook that causes incorrect display of the doc:

TempCirqOperations

@LaurentAjdnik LaurentAjdnik requested review from cduck, vtomole and a team as code owners July 14, 2021 14:36
@google-cla
Copy link

google-cla bot commented Jul 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla google-cla bot added the cla: no label Jul 14, 2021
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@LaurentAjdnik
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Makes googlebot stop complaining. and removed cla: no labels Jul 14, 2021
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, one small thing: Could we change Operations to Operations because cirq.Operation exists, but not cirq.Operations.

@LaurentAjdnik
Copy link
Contributor Author

Actually, one small thing: Could we change Operations to Operations because cirq.Operation exists, but not cirq.Operations.

I sure can. But Operations already appears as such eight times. Just like Moments is used twice instead of Moments.

Should I change them all? I agree this would be more logical.

@vtomole
Copy link
Collaborator

vtomole commented Jul 14, 2021

Oh i see. That's fine then. Let's leave it as-is because I bet the conventions that exist at the moment are not restricted to this file.

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 14, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 14, 2021
@CirqBot CirqBot merged commit 0d8bf31 into quantumlib:master Jul 14, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 14, 2021
@LaurentAjdnik LaurentAjdnik deleted the docs_circuits_typo branch July 14, 2021 21:11
erichulburd pushed a commit to erichulburd/Cirq that referenced this pull request Jul 15, 2021
Adds a missing quote in the Circuits notebook that causes incorrect display of the doc:

![TempCirqOperations](https://user-images.githubusercontent.com/83899250/125640450-7fbcc35c-c8cb-4c03-af46-37f2ab235c11.png)
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Adds a missing quote in the Circuits notebook that causes incorrect display of the doc:

![TempCirqOperations](https://user-images.githubusercontent.com/83899250/125640450-7fbcc35c-c8cb-4c03-af46-37f2ab235c11.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants