3D circuit visualization using Typescript dev environment #4334
Conversation
| * displayed using three.js | ||
| */ | ||
| export class GridCircuit extends Group { | ||
| readonly moments: number; |
There was a problem hiding this comment.
A still outstanding issue. I wonder about this number as well - why do we need it at all? It seems like that this is just used as the initial default moment number for the qubits... Consider just passing it in to the private addQubit method and then we don't even have to store it. Also rename to initial_num_moments.
| * Class constructor | ||
| * @param moments The number of moments of the circuit. This | ||
| * determines the length of all the qubit lines in the diagram. | ||
| * @param qubits A list of GridCoord objects representing the locations of the |
There was a problem hiding this comment.
+1 to the suggestion, it would be more Cirq-y as well - though that might be a bit of a larger refactoring at this point.
There was a problem hiding this comment.
Looks good - the last thing is the docstring in grid_circuit, as I commented above. Also maybe in a follow-up PR, I would change the e2e test to display a bit richer circuit with all the symbols at an angle that it shows the X in the middle of the circle for X gates, but other than that it looks great!
balopat
added
automerge
balopat
removed
automerge
…#4334) ### 3D circuit visualization This PR implements the features discussed in the [3D Quantum Circuits RFC](https://docs.google.com/document/d/1dLKj8oAF_JhDWU4zLU7XMz3aBXymd0hk_9n6U0mEtms/edit?usp=sharing). #### Relevant Issues and PRs quantumlib#1075 - 3D diagrams for circuits quantumlib#4171 - Typescript development in Cirq and prototype bloch sphere implementation #### Features implemented - All features of a [Cirq Typescript widget](quantumlib#4171) - End to end display of circuits - Serialization of cirq.Circuit objects, re-representation in Typescript - Support for arbitrary length gates - Testing for the different components - A short jupyter notebook example https://user-images.githubusercontent.com/17647506/126213608-0c2d09d1-d5c2-4fa0-a8ae-3f0780f09912.mp4
3D circuit visualization
This PR implements the features discussed in the 3D Quantum Circuits RFC.
Relevant Issues and PRs
#1075 - 3D diagrams for circuits
#4171 - Typescript development in Cirq and prototype bloch sphere implementation
Features implemented
capture.5.mp4