Complete implementation of the permit_mixed_moments option #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrwojtek
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
mpharrigan
approved these changes
Jul 21, 2021
| @@ -1022,16 +1049,32 @@ def _make_zeta_chi_gamma_compensation( | |||
| new_moment_moment_to_calibration == corrections.moment_to_calibration | |||
| ), f'Inconsistent decompositions with a moment {moment}' | |||
|
|
|||
| if other and decompositions: | |||
| raise IncompatibleMomentError(f'Moment {moment} contains mixed operations') | |||
| if decompositions: | |||
There was a problem hiding this comment.
this function is getting rather huge and this logic is rather hairy. Clean up ideas
- refactor line 1003--1050 into a helper function so it's clear what the inputs and outputs for this segment is and you can give it a helpful name. Then you can document the meaning of "decompositions" and "other"
- otherwise, at least add line comments saying what decompositions and other are
- This may result in some duplicated code, but can you factor the four possible values of
(bool(decompositions), bool(other))into four cases or helper functions? the fall-thru logic going on now makes it pretty hard to follow. Once again, helper functions could go a long way to documenting implicitly and explicitly what variables are being set by each block of code.
There was a problem hiding this comment.
I did slightly different which I think makes more sense: I extracted the entire loop into a separate method. WDYT?
There was a problem hiding this comment.
Yes, this looks nicer. Although Github's diff is having a hard time with it :)
mpharrigan
approved these changes
Jul 22, 2021
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…b#4342) * Complete implementation of the permit_mixed_moments option * Fix mypy issues * Refactor _make_zeta_chi_gamma_compensation * Fix typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to mix single-qubit and two-qubit operations during calibration. This might be especially useful for creating circuits with spin-echo for example.