Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floquet quirk url #4347

Merged
merged 2 commits into from Jul 26, 2021
Merged

Fix floquet quirk url #4347

merged 2 commits into from Jul 26, 2021

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jul 22, 2021

In the floquet example notebook, this changes the quirk example circuit's URL to the escaped version as the unescaped one is unpublishable in the devsite pipeline.

@balopat balopat requested review from cduck, vtomole, wcourtney and a team as code owners July 22, 2021 13:43
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jul 22, 2021
rmlarose
rmlarose approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@rmlarose rmlarose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, did check/nbformat --apply modify the url at all? Or you had to manually format the url?

@balopat
Copy link
Contributor Author

balopat commented Jul 22, 2021 •
edited

I had to manually do the formatting, but the trick is to use quirk's export escaped url method:

image

dstrain115
dstrain115 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 26, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 26, 2021
@CirqBot CirqBot merged commit fb43b84 into quantumlib:master Jul 26, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 26, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@balopat @rht
Fix floquet quirk url (quantumlib#4347)
a15dc7f 
In the floquet example notebook, this changes the quirk example circuit's URL to the escaped version as the unescaped one is unpublishable in the devsite pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

@rmlarose rmlarose rmlarose approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@wcourtney wcourtney Awaiting requested review from wcourtney

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar

Assignees

@tanujkhattar tanujkhattar

Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@balopat @dstrain115 @rmlarose @tanujkhattar @CirqBot