Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size labels #4402

Merged
merged 13 commits into from
Aug 12, 2021
Merged

Size labels #4402

merged 13 commits into from
Aug 12, 2021

Conversation

MichaelBroughton
Copy link
Collaborator

@MichaelBroughton MichaelBroughton commented Aug 11, 2021

Adds automated size labeling for newly opened PRs. This should be helpful for gauging time needed for a particular PRs review. See #4401

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Aug 11, 2021
@@ -31,10 +31,19 @@
# the body of the PR's initial message/comment. Users/admins should edit the title and
# initial comment to appropriately describe the PR.
#
# This script will also automatically label PRs based on their code size. The following
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this script requires syncing with Fedor w.r.t. how the bot is run.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I thought @balopat had set this up on cloud using some of his Kubernetes wizardry. @fvkg What do you think ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I set this up and it is described in https://github.com/quantumlib/Cirq/tree/master/dev_tools/auto_merge.
Namely, rename the script in the Dockerfile here:

CMD ["python", "dev_tools/auto_merge.py"]

Note though that the whole folder is named auto_merge, so for consistency you might want to rename the whole thing to pr_monitor (not pr_moniter), or cirq_bot...

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 11, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 11, 2021
@CirqBot
Copy link
Collaborator

CirqBot commented Aug 11, 2021

Automerge cancelled: There are merge conflicts.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 11, 2021
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 11, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 11, 2021
@CirqBot CirqBot merged commit 4aeb719 into quantumlib:master Aug 12, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 12, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Adds automated size labeling for newly opened PRs. This should be helpful for gauging time needed for a particular PRs review. See quantumlib#4401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants