-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size labels #4402
Size labels #4402
Conversation
dev_tools/pr_moniter.sh
Outdated
@@ -31,10 +31,19 @@ | |||
# the body of the PR's initial message/comment. Users/admins should edit the title and | |||
# initial comment to appropriately describe the PR. | |||
# | |||
# This script will also automatically label PRs based on their code size. The following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming this script requires syncing with Fedor w.r.t. how the bot is run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I set this up and it is described in https://github.com/quantumlib/Cirq/tree/master/dev_tools/auto_merge.
Namely, rename the script in the Dockerfile here:
Cirq/dev_tools/auto_merge/Dockerfile
Line 37 in 10c78c9
CMD ["python", "dev_tools/auto_merge.py"] |
Note though that the whole folder is named auto_merge, so for consistency you might want to rename the whole thing to pr_monitor
(not pr_moniter
), or cirq_bot
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Automerge cancelled: There are merge conflicts. |
Adds automated size labeling for newly opened PRs. This should be helpful for gauging time needed for a particular PRs review. See quantumlib#4401
Adds automated size labeling for newly opened PRs. This should be helpful for gauging time needed for a particular PRs review. See #4401