Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel matrix -> superoperator #4433

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Channel matrix -> superoperator #4433

merged 3 commits into from
Aug 18, 2021

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Aug 17, 2021

Implements results of this vote. The vote will also affect the name of the corresponding protocol, but it is WIP.

@viathor viathor requested review from cduck, vtomole and a team as code owners August 17, 2021 04:13
@viathor viathor requested a review from balopat August 17, 2021 04:13
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Aug 17, 2021
@CirqBot CirqBot added the size: S 10< lines changed <50 label Aug 17, 2021
MichaelBroughton
MichaelBroughton reviewed Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These did make it into the previous public release. Do you think it might be worth deprecating the old names too ?

@viathor
Copy link
Collaborator Author

viathor commented Aug 18, 2021

PTAL

MichaelBroughton
MichaelBroughton approved these changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 18, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 18, 2021
@CirqBot CirqBot merged commit 601a923 into quantumlib:master Aug 18, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 18, 2021
vtomole
vtomole reviewed Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viathor viathor deleted the channel_matrix_to_superoperator branch August 18, 2021 16:51
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@viathor @rht
Channel matrix -> superoperator (quantumlib#4433)
6b558cf 
Implements results of [this vote](quantumlib#4179 (comment)). The vote will also affect the name of the corresponding protocol, but it is WIP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole left review comments

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@cduck cduck Awaiting requested review from cduck

@balopat balopat Awaiting requested review from balopat

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining. size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@viathor @MichaelBroughton @vtomole @CirqBot