Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SupportsKraus to cirq/__init__.py #4437

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Add SupportsKraus to cirq/__init__.py #4437

merged 3 commits into from
Aug 18, 2021

Conversation

vtomole
Copy link
Collaborator

@vtomole vtomole commented Aug 18, 2021

Fixes: #4425

@vtomole vtomole requested review from cduck and a team as code owners August 18, 2021 15:51
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Aug 18, 2021
@CirqBot CirqBot added the Size: XS <10 lines changed label Aug 18, 2021
@vtomole
Copy link
Collaborator Author

vtomole commented Aug 18, 2021

I can't request @viathor as a reviewer.

@vtomole
Copy link
Collaborator Author

vtomole commented Aug 18, 2021

Should I change the existing calls of SupportsChannel to SupportsKraus on here?

viathor
viathor approved these changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Victory!

@vtomole
Copy link
Collaborator Author

vtomole commented Aug 18, 2021

👍 . Oh just membered, we assign to pull requests if we can't assign to a reviewer.

@viathor
Copy link
Collaborator

viathor commented Aug 18, 2021

Should I change the existing calls of SupportsChannel to SupportsKraus on here?

Sorry for having missed those and thanks for sending this PR. I'll do the rest.

@vtomole
Copy link
Collaborator Author

vtomole commented Aug 18, 2021

I'll do the rest

Nah nah i'm on a roll. Will push the changes to PR.

@viathor
Copy link
Collaborator

viathor commented Aug 18, 2021

Hehe, ok! :-)
Thank you, Victory!

@viathor viathor merged commit 5ee2288 into quantumlib:master Aug 18, 2021
@vtomole vtomole mentioned this pull request Aug 18, 2021
Merged
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@vtomole @rht
Add SupportsKraus to cirq/__init__.py (quantumlib#4437)
2a2c217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

@cduck cduck Awaiting requested review from cduck

@mpharrigan mpharrigan Awaiting requested review from mpharrigan

Assignees

@viathor viathor

Labels
cla: yes Makes googlebot stop complaining. Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SupportsChannel deprecation is incorrect
3 participants
@vtomole @viathor @CirqBot