Noise validate and docs #4447
Merged
Noise validate and docs #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
requested changes
Aug 20, 2021
cirq-google/cirq_google/experimental/noise_models/validate_noise_model_from_calibration.py
Outdated
Show resolved
Hide resolved
cirq-google/cirq_google/experimental/noise_models/validate_noise_model_from_calibration.py
Outdated
Show resolved
Hide resolved
cirq-google/cirq_google/experimental/noise_models/validate_noise_model_from_calibration_test.py
Outdated
Show resolved
Hide resolved
cirq-google/cirq_google/experimental/noise_models/validate_noise_model_from_calibration_test.py
Outdated
Show resolved
Hide resolved
cirq-google/cirq_google/experimental/noise_models/validate_noise_model_from_calibration_test.py
Outdated
Show resolved
Hide resolved
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
95-martin-orion
requested changes
Aug 20, 2021
asmuzsoy
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
95-martin-orion
approved these changes
Aug 21, 2021
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['cla/google'] |
CirqBot
removed
automerge
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* preliminary implementation of just the physics channels for all metrics * cleaned up code a bit, initial physics implementation * consolidated p00/p11 to one channel, gets sycamore durations * separated measurement gates and others in fidelity * wrote tests to check individual metrics * added functionality to convert from Calibration to Fidelity and associated tests * functionality preliminarily finished, committing before splitting into 2 files * separated out calibration_to_fidelity and moved fidelity to cirq-core * apparently didn't commit the files properly in my last push * deleting old file locations * updated fidelity_test.py to improve coverage * moved calibration to fidelity files to cirq-google * addigng validate_calibration method * added validate_calibration and pauli average error * updated staged files & increased coverage * updated error messages and moved functions outside * updated comments as per suggestions * adjusted xeb fidelity from error, began validation code * tests are passing and improvied documentation * updated tutorial notebook and removed tests as recommended * cleared output in notebook * updated notebook as per comments * included tests for compare_generated_noise * tried to fix checks that fialed * updated test name and added TODO * fixed lint check * fixing coverage check by removing unecessary random seed * fixing format check * removed test because of flaking issue Co-authored-by: Ana Sofia Uzsoy <asuzsoy@google.com> Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.