Refactor ActOnArgs.kron/factor/transpose to reduce code duplication #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…uantumlib#4463) Step 3 for feedforward, outlined in https://tinyurl.com/cirq-feedforward. This PR reduces duplication by moving redundant code from ActOnArgs.kron etc, such as `qubits = self.qubits + other.qubits` into the ActOnArgs base class, and then using handlers in subclasses to append subclass-specific information. It also updates these methods with an `inplace` option to allow them to be consistent with the swap/rename methods added in quantumlib#4169 @95-martin-orion has the most context here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 3 for feedforward, outlined in https://tinyurl.com/cirq-feedforward.
This PR reduces duplication by moving redundant code from ActOnArgs.kron etc, such as
qubits = self.qubits + other.qubitsinto the ActOnArgs base class, and then using handlers in subclasses to append subclass-specific information. It also updates these methods with aninplaceoption to allow them to be consistent with the swap/rename methods added in #4169@95-martin-orion has the most context here.