Use gatesets in cirq/ion, cirq/neutral_atoms, cirq_pasqal and cirq_ionq #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
requested review from
cduck,
ColemanCollins,
dabacon,
gmauricio,
HGSilveri,
nakardo,
vtomole and
a team
as code owners
dabacon
reviewed
Sep 21, 2021
| cirq.XXPowGate, | ||
| cirq.YYPowGate, | ||
| cirq.ZZPowGate, | ||
| cirq.MeasurementGate, |
There was a problem hiding this comment.
Does this work for cirq.SWAP**3? Reading the gateset code I think it does, but wanted to check.
There was a problem hiding this comment.
Yes, it'll work for cirq.SWAP ** 3 because cirq.SWAP ** 3 == cirq.SWAP and the gateset will use value equality by default for gate instances.
|
Can we split this up into two separate PRs ? One for |
|
Sent out Marking this as a draft for now. |
|
Smaller individual PRs have been sent out and we can close this one now. |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…uantumlib#4517) This PR introduces new common gate families which will be useful to adopt the usage of Gatesets across Cirq. This is split off the larger PR quantumlib#4513 and follow up PRs will use these new gate families. Part of the roadmap item quantumlib#3243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the use of newly added
cirq.GateFamilyandcirq.Gatesetclasses incirq/ion,cirq/neutral_atoms,cirq_pasqalandcirq_ionq.Note that functions
is_native_neutral_atom_opandis_native_neutral_atom_gateare now moot, but are part of the public API and hence are not removed. We can deprecate them later -- though, IMO, bothcirq/ionandcirq/neutral_atomsmodules should be deprecated :)Follow up PRs will further adopt the use of Gatesets in
cirq/optimizersandcirq_google/This is part of the roadmap item #3243