New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken path instructions in setting up a dev environment #4519
Conversation
docs/dev/development.md
Outdated
python dev_tools/modules.py list --mode package-path > | ||
``` | ||
and then adding these to the virtualenv: | ||
```bash | ||
add2virtualenv <paste modules from last command> | ||
``` | ||
(Typically `add2virtualenv` is not executable using xargs, so this two step process is necessary.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So why exactly does something likeadd2virtualenv "$(python dev_tools/modules.py list --mode package-path | xargs)"
not work ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because add2virtualenv is a shell function. Depending on how this shell function was installed, one can do xargs bash -c "add2virtualenv ..." But this doesn't always work depending on how virtualenvwrapper.sh is set up.
The alternative here is to add a command to dev_tools to change the path, which I think is doable. Want this @MichaelBroughton ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhhh in that case I'm not too bothered. I think adding an extra command is totally fine. I don't think this little sequence here warrants its own dev_tools command.
…lib#4519) For the add2virtualenv I could only figure out a way to do it in two steps (this was on mac running big sur). If anyone has some shell foo to make this one line, that would be great.
For the add2virtualenv I could only figure out a way to do it in two steps (this was on mac running big sur). If anyone has some shell foo to make this one line, that would be great.