Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any qubit type in quimb density matrix #4547

Merged
merged 4 commits into from Oct 14, 2021

Conversation

mpharrigan
Copy link
Collaborator

Used to restrict to linequbit just to make positioning easier when drawing the tensor networks. Now instead of using q.x, we use qubits.index(q) to find a qubits linear position.

@mpharrigan mpharrigan requested review from cduck, vtomole and a team as code owners October 4, 2021 17:58
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Oct 4, 2021
@CirqBot CirqBot added the size: M 50< lines changed <250 label Oct 4, 2021
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document that the qubit index determines the positioning somewhere?

Otherwise, it seems fine to me.

@mpharrigan
Copy link
Collaborator Author

added a line to the docstring

@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 14, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 14, 2021
@CirqBot
Copy link
Collaborator

CirqBot commented Oct 14, 2021

Automerge cancelled: A required status check is not present.

Missing statuses: ['Build docs', 'Build protos', 'Coverage check', 'Lint check', 'Misc check', 'Notebook formatting', 'Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Type check', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 14, 2021
@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 14, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 14, 2021
@CirqBot CirqBot merged commit aaf969d into quantumlib:master Oct 14, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 14, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Used to restrict to linequbit just to make positioning easier when drawing the tensor networks. Now instead of using `q.x`, we use `qubits.index(q)` to find a qubits linear position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining. size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants