More channel representation conversion tools #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
approved these changes
Oct 5, 2021
|
|
||
|
|
||
| def superoperator_to_choi(superoperator: np.ndarray) -> np.ndarray: | ||
| """Returns the Choi matrix of a quantum channel specified via the superoperator matrix.""" |
There was a problem hiding this comment.
do we have documentation anywhere that defines what these representations are? If no: we should beef up these docstrings to give some context for the conversion.
In any case, it could be helpful to give a little note about how "involved" each conversion is. E.g. add a line: "Conversions between superoperator and choi representations only involve axes manipulation"
"Conversions to kraus require an eigendecomposition"
There was a problem hiding this comment.
Good point. I'll send thorough updates to docstrings in a separate PR.
There was a problem hiding this comment.
Done in #4554 (both definitions of the mathematical objects and the notes about complexity).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR one can convert between any two representations from among: Kraus, Choi and superoperator.