Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move examples to top level #458

Merged
merged 1 commit into from Jun 13, 2018
Merged

Move examples to top level #458

merged 1 commit into from Jun 13, 2018

Conversation

Strilanc
Copy link
Contributor

@Strilanc Strilanc requested a review from dabacon June 13, 2018 00:32
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jun 13, 2018
@dabacon
Copy link
Collaborator

dabacon commented Jun 13, 2018

Can you check that this doesn't make using http://www.sphinx-doc.org/en/stable/markup/code.html#directive-literalinclude really ugly?

dabacon
dabacon requested changes Jun 13, 2018
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check that this doesn't make using http://www.sphinx-doc.org/en/stable/markup/code.html#directive-literalinclude really ugly?

@dabacon dabacon merged commit b804bd5 into master Jun 13, 2018
@Strilanc
Copy link
Contributor Author

Strilanc commented Jun 13, 2018 •
edited

@dabacon Did you check that it works? I hadn't checked yet.

@Strilanc Strilanc deleted the move-examples branch June 13, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabacon dabacon dabacon approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Strilanc @dabacon @googlebot