-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to pylint 2.13 #5156
Update to pylint 2.13 #5156
Changes from all commits
9c3e30a
160fd10
d5e509a
7bb7f8e
3864b51
72d3889
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,6 @@ enable= | |
missing-raises-doc, | ||
mixed-indentation, | ||
mixed-line-endings, | ||
not-callable, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was this removed ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is better handled by mypy, because it's an actual type-checker that can tell if something is callable. pylint relies on heuristics to figure out if something is callable and was producing false positives (@Strilanc filed an issue about this upstream: pylint-dev/pylint#2562). |
||
no-value-for-parameter, | ||
nonexistent-operator, | ||
not-in-loop, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
# for linting | ||
|
||
pylint~=2.6.0 | ||
pylint~=2.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this unexpected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT it's a false positive from pylint. I don't know how it tries to infer the type and figure out what args are allowed, and various things I tried didn't help. We could also disable this pylint check entirely since it's probably better handled by mypy (similar to the
not-callable
check).