Consistent final_state_vector #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Shout-out to @tanujkhattar for the Transformers API - it massively simplified the process of migrating drop-terminal-measurements behavior from in-simulation to pre-simulation. Thanks Tanuj! |
tanujkhattar
requested changes
Apr 25, 2022
tanujkhattar
approved these changes
May 9, 2022
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Fixes quantumlib#3693. This pushes `Circuit.final_state_vector` and `mux.final_state_vector` towards a shared API of: ```python def final_state_vector( program: 'cirq.CIRCUIT_LIKE', *, initial_state: 'cirq.STATE_VECTOR_LIKE' = 0, param_resolver: 'cirq.ParamResolverOrSimilarType' = None, qubit_order: 'cirq.QubitOrderOrList' = ops.QubitOrder.DEFAULT, ignore_terminal_measurements: bool = False, dtype: Type[np.number] = np.complex64, seed: 'cirq.RANDOM_STATE_OR_SEED_LIKE' = None, ) -> 'np.ndarray': ``` Additionally, calls to `Circuit.final_state_vector` will now pass through the simulator instead of using `apply_unitary`. Notable changes in `Circuit`: - `qubits_that_should_be_present` is deprecated - Use of positional args is deprecated - The default of `ignore_terminal_measurements` will change to `False` in v0.16 - The default of `dtype` has directly changed to `np.complex64` Notable changes in `mux`: - Addition of `ignore_terminal_measurements` parameter Other changes: - Added `drop_terminal_measurements` transformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3693.
This pushes
Circuit.final_state_vectorandmux.final_state_vectortowards a shared API of:Additionally, calls to
Circuit.final_state_vectorwill now pass through the simulator instead of usingapply_unitary.Notable changes in
Circuit:qubits_that_should_be_presentis deprecatedignore_terminal_measurementswill change toFalsein v0.16dtypehas directly changed tonp.complex64Notable changes in
mux:ignore_terminal_measurementsparameterOther changes:
drop_terminal_measurementstransformer