Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check controlled subgate/op has mixture #5294

Merged
merged 4 commits into from
May 3, 2022

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Apr 26, 2022

Check controlled subgate/op is not measurement, and has mixture if not parameterized. Add tests for this, and update tests that were broken by the check.

Fixes #4007
Fixes #5287

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners April 26, 2022 15:40
@CirqBot CirqBot added the size: M 50< lines changed <250 label Apr 26, 2022
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of docs requests, all code looks good.

cirq-core/cirq/ops/controlled_gate.py Outdated Show resolved Hide resolved
cirq-core/cirq/ops/controlled_gate.py Outdated Show resolved Hide resolved
@95-martin-orion 95-martin-orion merged commit 4ad6eb0 into quantumlib:master May 3, 2022
@daxfohl daxfohl deleted the controlled-init branch May 3, 2022 16:46
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Check controlled subgate/op has mixture

* Fix tests

* doc updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ControlledGate/Op allows measurements and channels as sub-op Support controlled CircuitOperations
3 participants