Update Neutral Atoms to Transformers #5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create function convert_to_neutral_atom_gateset() to replace PointOptimizer ConvertToNeutralAtomGateset. Create NeutralAtomGateset that works as a compilation target gateset.
tanujkhattar
requested changes
May 2, 2022
|
|
||
| if TYPE_CHECKING: | ||
| import cirq | ||
|
|
||
|
|
||
| @transformers.transformer | ||
| def convert_to_neutral_atom_gates( |
There was a problem hiding this comment.
I think we should just update the deprecation message in ConvertToNeutralAtomGates to point users to the cirq.optimize_for_target_gateset(circuit, gateset=cirq.NeutralAtomGateset) API instead of creating this additional transformer which is essentially just a wrapper. WDYT ?
|
|
||
|
|
||
| class NeutralAtomGateset(transformers.CompilationTargetGateset): | ||
| def __init__(self, max_parallel_z=None, max_parallel_xy=None): |
There was a problem hiding this comment.
nit: Add type annotations to arguments.
| import cirq | ||
|
|
||
|
|
||
| class NeutralAtomGateset(transformers.CompilationTargetGateset): |
Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
tanujkhattar
approved these changes
May 2, 2022
cirq-core/cirq/__init__.py
Outdated
| @@ -668,6 +668,7 @@ | |||
|
|
|||
| from cirq.ion import ConvertToIonGates, IonDevice, ms, two_qubit_matrix_to_ion_operations | |||
| from cirq.neutral_atoms import ( | |||
| convert_to_neutral_atom_gates, | |||
|
|
||
| if TYPE_CHECKING: | ||
| import cirq | ||
|
|
||
|
|
||
| @deprecated_class( | ||
| deadline='v0.16', | ||
| fix='Use cirq.optimize_for_target_gateset(' + 'circuit, gateset=NeutralAtomGateset()).', |
There was a problem hiding this comment.
Why the break into 2 different strings?
| return 2 | ||
|
|
||
| def decompose_to_target_gateset(self, op: 'cirq.Operation', moment_idx: int) -> DecomposeResult: | ||
| """Method to rewrite the given operation using gates from this gateset. |
There was a problem hiding this comment.
Add to the docstring that 2q gates are decomposed into CZs because "CZ gates are the highest fidelity 2-qubit gates for neutral atoms." (quoted from docstring of ConvertToNeutralAtomGates optimizer)
This was referenced May 4, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Update Neutral Atoms to Transformers Create NeutralAtomGateset that works as a compilation target gateset. Point ConvertToNeutralAtomGateset towards optimize_for_target_gateset instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create function convert_to_neutral_atom_gateset() to
replace PointOptimizer ConvertToNeutralAtomGateset.
Create NeutralAtomGateset that works as a compilation target
gateset.