Add json serialization to SycamoreTargetGateset. #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verult
requested review from
wcourtney,
a team,
vtomole and
cduck
as code owners
| @@ -0,0 +1 @@ | |||
| cirq_google.SycamoreTargetGateset(atol=1e-08, tabulation=None) | |||
There was a problem hiding this comment.
The repr json combo might need to go in the cirq_google json_test_data directory ?
There was a problem hiding this comment.
Oops my bad, thanks for the catch!
verult
force-pushed
the
sycaremore-target-gateset-json
branch
from
b97237d
to
9130aeb
Compare
verult
force-pushed
the
sycaremore-target-gateset-json
branch
from
9130aeb
to
512182b
Compare
tanujkhattar
reviewed
May 2, 2022
A repr/json with tabulation set is omitted because the repr of cirq.two_qubit_gate_product_tabulation() is very long.
verult
force-pushed
the
sycaremore-target-gateset-json
branch
from
512182b
to
a9085bf
Compare
tanujkhattar
approved these changes
May 2, 2022
verult
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
This makes it possible to fully serialize `GridDeviceMetadata`. A repr/json with tabulation set is omitted because the repr of cirq.two_qubit_gate_product_tabulation() is very long. @tanujkhattar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to fully serialize
GridDeviceMetadata.A repr/json with tabulation set is omitted because the repr of cirq.two_qubit_gate_product_tabulation() is very long.
@tanujkhattar