Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pad inhomogenous result arrays #5319

Merged
merged 3 commits into from
May 3, 2022
Merged

Pad inhomogenous result arrays #5319

merged 3 commits into from
May 3, 2022

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented May 2, 2022

Pads inhomogeneous arrays returned by simulators for nondeterministic circuits

Fixes #5318

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners May 2, 2022 17:38
@daxfohl daxfohl requested a review from viathor May 2, 2022 17:38
@CirqBot CirqBot added the size: S 10< lines changed <50 label May 2, 2022
MichaelBroughton
MichaelBroughton reviewed May 3, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Since this is a somewhat frequently used code path for the simulators, I'm wondering if we can tighten up the performance a little bit. What do you think ?

cirq-core/cirq/sim/simulator_base.py Outdated Show resolved Hide resolved
cirq-core/cirq/sim/simulator_base.py Outdated Show resolved Hide resolved
@MichaelBroughton MichaelBroughton self-assigned this May 3, 2022
MichaelBroughton
MichaelBroughton approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 3, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 3, 2022
@CirqBot CirqBot merged commit 4ba9788 into quantumlib:master May 3, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels May 3, 2022
@daxfohl daxfohl deleted the pad branch May 4, 2022 04:43
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @rht
Pad inhomogenous result arrays (quantumlib#5319)
79ff9a3 
Pads inhomogeneous arrays returned by simulators for nondeterministic circuits

Fixes quantumlib#5318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repeat_until incompatible with run repetitions
3 participants
@daxfohl @MichaelBroughton @CirqBot