-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove execution result from notebooks #5326
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Are we sure that this example will run in devsite? I seem to recall that we saved outputs on the azure notebook to avoid trying to execute it during CI |
That was the question I asked @MichaelBroughton . Where do we find excluded notebooks? |
I take it from your comment @dstrain115 that if it has executed code it doesn't execute it during the CI? Seems very fragile to me. I'll remove Azure and IonQ as I think those are likely to need the executed code. |
Yes, if we store executed results, they are not executed in dev site. |
I've removed the notebooks that talk to services. |
CirqBot you are bad at judging size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. Can we just outright cut the ion_device
tutorial. Things are looking pretty outdated there. Thoughts @dstrain115 ?
Filing #5463 to decide about ion device notebook |
This removes execution results from notebooks. @MichaelBroughton these are causing downstream failure with docs build. Where do I figure out if these are being built when we push these out? i.e. I'm not certain that the azure notebooks get built with results and don't want to strip these results if this actually isn't built.
This removes execution results from notebooks.
@MichaelBroughton these are causing downstream failure with docs build. Where do I figure out if these are being built when we push these out? i.e. I'm not certain that the azure notebooks get built with results and don't want to strip these results if this actually isn't built.