Minor (cosmetic changes) #5329
Merged
Minor (cosmetic changes) #5329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a parenthesis I think is required. Fixed a sentence, I think the word "rotation" was missing.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
dabacon
approved these changes
May 4, 2022
examples/hhl.py
Outdated
| @@ -148,7 +148,7 @@ def _decompose_(self, qubits): | |||
|
|
|||
|
|
|||
| class EigenRotation(cirq.Gate): | |||
| """Perform the of the ancilla equivalent to divison of the memory by eigenvalues of matrix. | |||
| """Perform the rotation of the ancilla equivalent to divison of the memory by eigenvalues of matrix. | |||
There was a problem hiding this comment.
Lint is yelling about over 100 chars (and pythonistas tend to want single line first sentences). Maybe
"""Perform a rotation on an ancilla equivalent to division by eigenvalues of a matrix."""
Changed the comment to not exceed the line limits.
|
Thanks. Changed the comment and signed the CLA (for my private account).
…On Tue, May 3, 2022 at 9:11 PM Dave Bacon ***@***.***> wrote:
***@***.**** approved this pull request.
Sorry for the bureaucracy. The google bot wants a signed CLA. As a googler
you can go to go/github and register this account. Or for personal use,
just sign the CLA.
One comment that our linter flagged.
------------------------------
In examples/hhl.py
<#5329 (comment)>:
> @@ -148,7 +148,7 @@ def _decompose_(self, qubits):
class EigenRotation(cirq.Gate):
- """Perform the of the ancilla equivalent to divison of the memory by eigenvalues of matrix.
+ """Perform the rotation of the ancilla equivalent to divison of the memory by eigenvalues of matrix.
Lint is yelling about over 100 chars (and pythonistas tend to want single
line first sentences). Maybe
"""Perform a rotation on an ancilla equivalent to division by eigenvalues
of a matrix."""
—
Reply to this email directly, view it on GitHub
<#5329 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASSDND2YHN2B2YE54FPL3LTVIH2INANCNFSM5VAOGMKA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Robert Hundt
|
examples/hhl.py
Outdated
| """Perform the of the ancilla equivalent to divison of the memory by eigenvalues of matrix. | ||
|
|
||
| """Perform a rotation on an ancilla equivalent to division by eigenvalues of a matrix. | ||
There was a problem hiding this comment.
Nit: remove spaces / tabs on a blank line.
Removed the spaces. I really shouldn't use the github web editor...
dstrain115
approved these changes
May 6, 2022
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Added a parenthesis I think is required. Fixed a sentence, I think the word "rotation" was missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parenthesis I think is required.
Fixed a sentence, I think the word "rotation" was missing.