-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api docs simulators #5333
Api docs simulators #5333
Conversation
- Update references to latest names - Clean up some wording, since there were some really long run-on sentences that went on forever, since sentences should not contain too many phrases, such as clauses with too many commas and other things like this that are very long and try to explain too much stuff in a single sentence without stopping ever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I am not sure if this is a long enough review to merit a detailed discussion of the single nit that I put in this code review and whether or not I should have just not put it there.
cirq-core/cirq/work/sampler.py
Outdated
@@ -60,6 +70,10 @@ async def run_async( | |||
) -> 'cirq.Result': | |||
"""Asynchronously samples from the given Circuit. | |||
|
|||
Provides measurement outcomes as a `Result` object. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe cirq.Result
in this one so it links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
* Update Sparse Simu;ator api documents - Update references to latest names - Clean up some wording, since there were some really long run-on sentences that went on forever, since sentences should not contain too many phrases, such as clauses with too many commas and other things like this that are very long and try to explain too much stuff in a single sentence without stopping ever.
run-on sentences that went on forever, since sentences should
not contain too many phrases, such as clauses with too many
commas and other things like this that are very long and try
to explain too much stuff in a single sentence without stopping
ever.