Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api docs simulators #5333

Merged
merged 4 commits into from
May 9, 2022
Merged

Conversation

dstrain115
Copy link
Collaborator

  • Update references to latest names
  • Add more information to sampler interface docs.
  • Clean up some wording, since there were some really long
    run-on sentences that went on forever, since sentences should
    not contain too many phrases, such as clauses with too many
    commas and other things like this that are very long and try
    to explain too much stuff in a single sentence without stopping
    ever.

- Update references to latest names
- Clean up some wording, since there were some really long
run-on sentences that went on forever, since sentences should
not contain too many phrases, such as clauses with too many
commas and other things like this that are very long and try
to explain too much stuff in a single sentence without stopping
ever.
@dstrain115 dstrain115 requested review from a team, vtomole and cduck as code owners May 5, 2022 18:11
@dstrain115 dstrain115 requested a review from viathor May 5, 2022 18:11
@CirqBot CirqBot added the size: M 50< lines changed <250 label May 5, 2022
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I am not sure if this is a long enough review to merit a detailed discussion of the single nit that I put in this code review and whether or not I should have just not put it there.

@@ -60,6 +70,10 @@ async def run_async(
) -> 'cirq.Result':
"""Asynchronously samples from the given Circuit.

Provides measurement outcomes as a `Result` object. This
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe cirq.Result in this one so it links?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dstrain115 dstrain115 merged commit b2f3d8a into quantumlib:master May 9, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Update Sparse Simu;ator api documents

- Update references to latest names
- Clean up some wording, since there were some really long
run-on sentences that went on forever, since sentences should
not contain too many phrases, such as clauses with too many
commas and other things like this that are very long and try
to explain too much stuff in a single sentence without stopping
ever.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants