Handle inverse for Quil's SWAP gate #5341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabacon
reviewed
May 10, 2022
cirq-core/cirq/ops/swap_gates.py
Outdated
| @@ -143,7 +143,7 @@ def _qasm_(self, args: 'cirq.QasmArgs', qubits: Tuple['cirq.Qid', ...]) -> Optio | |||
| def _quil_( | |||
| self, qubits: Tuple['cirq.Qid', ...], formatter: 'cirq.QuilFormatter' | |||
| ) -> Optional[str]: | |||
| if self._exponent == 1: | |||
| if self._exponent == 1 or self._exponent == -1: | |||
There was a problem hiding this comment.
Is _exponent restricted in any way? If not, I think this should be any odd power. i.e. if self._exponent % 2 == 1:
There was a problem hiding this comment.
I don't know if it's restricted but your suggestion makes this more robust so i did it anyway.
dabacon
approved these changes
May 10, 2022
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
|
@dabacon Thanks!! |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
`SWAP` is it's own self inverse. Fixes: quantumlib#5310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWAPis it's own self inverse. Fixes: #5310