IonQ: Include json body of error response when possible #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cynocracy
requested review from
dabacon,
ColemanCollins,
nakardo,
gmauricio,
a team,
vtomole and
cduck
as code owners
Cynocracy
changed the title
ColemanCollins
approved these changes
May 11, 2022
|
love good error messages |
dabacon
reviewed
May 12, 2022
cirq-ionq/cirq_ionq/ionq_client.py
Outdated
| error = {} | ||
| try: | ||
| error = response.json() | ||
| except json.decoder.JSONDecodeError: |
There was a problem hiding this comment.
I think this will reference json from the parameter. Probably best solution is to import json.decoder as jd or something like that and then us that reference here.
There was a problem hiding this comment.
ha, right! Thanks for catching
There was a problem hiding this comment.
Thinking about this more, I probably shouldn't coverage ignore the except case if I already did a bug
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.