Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor aqt doc fixes #5358

Merged
merged 3 commits into from
May 13, 2022
Merged

Conversation

dstrain115
Copy link
Collaborator

  • Change one link that doesn't work.
  • Change to 80 character lines for my own sanity
  • Add some commas and a few minor grammatical changes.

- Change one link that doesn't work.
- Change to 80 character lines for my own sanity
- Add some commas and a few minor grammatical changes.
@dstrain115 dstrain115 requested review from ma5x, pschindler, a team, vtomole and cduck as code owners May 12, 2022 20:13
@CirqBot CirqBot added the size: S 10< lines changed <50 label May 12, 2022
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One requested change (think we may want to do an audit of our logs for external links?)

ranging from real-hardware ion traps with various number of ions to
quantum computing simulators including different noise models.
To get an overview of available devices visit
[www.aqt.eu](https://www.aqt.eu) and get direct access to the devices via the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add {:.external} to external links per https://www.tensorflow.org/community/contribute/docs_style

Below as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I need to remember this! Done.

@dstrain115 dstrain115 merged commit 3f0a782 into quantumlib:master May 13, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Minor aqt doc fixes

- Change one link that doesn't work.
- Change to 80 character lines for my own sanity
- Add some commas and a few minor grammatical changes.
- Add external link annotation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants