Add entangler errors to median data #5364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
|
Thanks especially to @dkafri for the tools necessary to extract this data - once I found the matching dataset it was pretty much a one-click process. |
|
Does it make sense for there to be a test to check that all the expected types of data are present? |
Glad it was helpfu! |
Done. Also tacked on a value-check for Weber to ensure we have the right dataset. |
dstrain115
approved these changes
May 18, 2022
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
CirqBot
pushed a commit
that referenced
this pull request
Jun 8, 2022
This PR adds Z phase angles for sqrt-ISWAP gates and tools for accessing them. Follow-up to #5364. Z phase angles are captured in a different calibration process than the other error metrics, and thus require a slightly different pipeline to access them. Key points to note about this data: - This only includes zeta and gamma, as theta and phi already appear in the QCS metrics and chi is not currently captured by any calibration process we use. - Qubit (6, 1) was in a bad state when the Weber data was taken, and thus has no Z phase angles in the sample data. The pipeline will treat this as zeta=gamma=0 for gates touching this qubit.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Adds theta and phi entangling angles to published median data. These weren't part of the exposed QCS metrics when this calibration was run, but we were able to reconstruct them from historical data stored internally. The latest QCS calibration metrics report these by default.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
This PR adds Z phase angles for sqrt-ISWAP gates and tools for accessing them. Follow-up to quantumlib#5364. Z phase angles are captured in a different calibration process than the other error metrics, and thus require a slightly different pipeline to access them. Key points to note about this data: - This only includes zeta and gamma, as theta and phi already appear in the QCS metrics and chi is not currently captured by any calibration process we use. - Qubit (6, 1) was in a bad state when the Weber data was taken, and thus has no Z phase angles in the sample data. The pipeline will treat this as zeta=gamma=0 for gates touching this qubit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds theta and phi entangling angles to published median data.
These weren't part of the exposed QCS metrics when this calibration was run, but we were able to reconstruct them from historical data stored internally. The latest QCS calibration metrics report these by default.