Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rigetti Getting Started Docs Cleanup #5372

Merged
merged 5 commits into from
Jun 2, 2022

Conversation

dstrain115
Copy link
Collaborator

  • Cleared outputs for testing
  • Changed service name to be programmatic, since it has changed
    from 'Aspen-9' to 'Aspen-11'.
  • Changed links to be external.

- Cleared outputs for testing
- Changed service name to be programmatic, since it has changed
from 'Aspen-9' to 'Aspen-11'.
- Changed links to be external.
@dstrain115 dstrain115 requested review from a team, vtomole and cduck as code owners May 16, 2022 23:33
@dstrain115 dstrain115 requested a review from maffoo May 16, 2022 23:33
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: L 250< lines changed <1000 label May 16, 2022
@@ -11,7 +11,7 @@
},
Copy link
Collaborator

@dabacon dabacon May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know if {:external} works for notebooks...I've only confirmed it for markdown / api docs.


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out. I'll remove it if it doesn't work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg

@@ -11,7 +11,7 @@
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to preserve output because this hits an external service to run? (similar below)?


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we can clear output. Since it uses as_qvm=True then it is all local.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of questions

Copy link
Collaborator

@augustehirth augustehirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 2, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 2, 2022
@CirqBot CirqBot merged commit 1b7b9e6 into quantumlib:master Jun 2, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 2, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
- Cleared outputs for testing
- Changed service name to be programmatic, since it has changed
from 'Aspen-9' to 'Aspen-11'.
- Changed links to be external.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants