Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major organizational restructure of top level tabs #5394

Merged
merged 8 commits into from
May 26, 2022

Conversation

augustehirth
Copy link
Collaborator

@augustehirth augustehirth commented May 23, 2022

Meaningful component steps:

  • Rename noise.ipynb -> noisy_simulation.ipynb and transform.ipynb -> transformers.ipynb
  • Fix linking per the above renaming
  • Add new, barebones _index.yaml outline pages for new top level categories
  • Update _book.yaml to recategorize most pages under the new top level categories and remove pages serving now-unavailable QCS content.

Successfully staged.

Should only be merged with quantumlib/ReCirq#294
One issue yet to be resolved is that of the cirq/experiments page. Currently, the ReCirq directory has an index.md file that is being overwritten by the new experiments/_index.yaml file provided in this Cirq directory. We need the new file here to create the left navigation bar for the pages under the experiments tab that are hosted in Cirq, not ReCirq. This new experiments/_index.yaml file is currently a barebones outline of the elements available in the experiments/ tab, but tries to link out to the ReCirq experiments/index.md file. The docs pipeline overwrites this old file at the moment. I am working on a solution for this that would depend on a ReCirq PR, but wanted to get this PR out for review ahead of that.

Scheduled for down the line after this PR merges:

  • Actually moving the files themselves under the new category directories + setting up redirects
  • More detailed outlines

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me modulo some ntis, but maybe some one else should also review.

docs/build/_index.yaml Outdated Show resolved Hide resolved
docs/noise/_index.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustehirth augustehirth merged commit 3883e29 into quantumlib:master May 26, 2022
augustehirth added a commit to quantumlib/ReCirq that referenced this pull request May 27, 2022
@augustehirth augustehirth deleted the restructure branch June 6, 2022 19:16
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Rename top pages

* Fix links for renamed pages

* New tabs, move pages, add outline pages for tabs

* Minor heading renaming

* Fix some more linking

* Fix indices to work with recirq research page fix

* Feedback changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants