-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major organizational restructure of top level tabs #5394
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me modulo some ntis, but maybe some one else should also review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Site indices fix to support quantumlib/Cirq#5394
* Rename top pages * Fix links for renamed pages * New tabs, move pages, add outline pages for tabs * Minor heading renaming * Fix some more linking * Fix indices to work with recirq research page fix * Feedback changes
Meaningful component steps:
Successfully staged.
Should only be merged with quantumlib/ReCirq#294
One issue yet to be resolved is that of the cirq/experiments page. Currently, the ReCirq directory has an index.md file that is being overwritten by the new experiments/_index.yaml file provided in this Cirq directory. We need the new file here to create the left navigation bar for the pages under the experiments tab that are hosted in Cirq, not ReCirq. This newexperiments/_index.yaml
file is currently a barebones outline of the elements available in theexperiments/
tab, but tries to link out to the ReCirqexperiments/index.md
file. The docs pipeline overwrites this old file at the moment. I am working on a solution for this that would depend on a ReCirq PR, but wanted to get this PR out for review ahead of that.Scheduled for down the line after this PR merges: