-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate implementation of _base_iterator #5402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat concerned about how this affects the simulation story - is SimulatorBase
now a valid superclass for external simulators? When should a simulator implement it vs. the other interfaces?
In related news, we really need to nail this down in documentation.
@95-martin-orion merging? |
Fixes quantumlib#5400 Add a deprecation warning that _base_iterator is going to be made abstract, and copy (with intent to move) the implementation to SimulatorBase. Once the deprecation timeline has passed we can safely make `SimulatesIntermediateState._base_iterator` abstract, and remove `_create_simulation_state`, `_create_act_on_args` and `_core_iterator` declarations from `SimulatesIntermediateState` completely. This makes `SimulatesIntermediateState` more true to its name, as it should not be concerned with how or where the subclass creates the initial state, even from the interface standpoint. @95-martin-orion
Fixes #5400
Add a deprecation warning that _base_iterator is going to be made abstract, and copy (with intent to move) the implementation to SimulatorBase.
Once the deprecation timeline has passed we can safely make
SimulatesIntermediateState._base_iterator
abstract, and remove_create_simulation_state
,_create_act_on_args
and_core_iterator
declarations fromSimulatesIntermediateState
completely. This makesSimulatesIntermediateState
more true to its name, as it should not be concerned with how or where the subclass creates the initial state, even from the interface standpoint.@95-martin-orion