Fix protobuf version specifiers in cirq-google/requirements.txt #5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
viathor
approved these changes
May 26, 2022
There was a problem hiding this comment.
Indeed, pip documentation says version specifiers follow PEP 440 which says
A version specifier consists of a series of version clauses, separated by commas. For example: ~= 0.9, >= 1.0, != 1.3.4.*, < 2.0
|
Thanks @maffoo, not sure how I missed the comma. |
augustehirth
pushed a commit
to augustehirth/Cirq
that referenced
this pull request
May 27, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an error in CI where pip was installing protobuf 4 (https://github.com/quantumlib/Cirq/runs/6606535751?check_suite_focus=true) and I think it was because the multiple version specifiers are supposed to be separated by a comma. Cleaned up the requirements file to add the comma as well as some whitespace for clarity (and consistency with the first line).