Deprecating cross_entropy_benchmarking and grid_parallel_two_qubit_xeb #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cirq.experiments.cross_entropy_benchmarking is redundant and not easy to adapt. - cirq.experiments.grid_parallel_two_qubit_xeb moved to recirq.benchmarks.xeb - Also delete cross_entropy_benchmarking example This is part of quantumlib#3775.
dstrain115
requested review from
mrwojtek,
a team,
vtomole and
cduck
as code owners
MichaelBroughton
approved these changes
May 31, 2022
| # Sanity test that plot runs. | ||
| ax = plt.subplot() | ||
| results_1.plot(ax) | ||
| with cirq.testing.assert_deprecated(_DEPRECATION_MESSAGE, deadline='v0.16', count=10): |
There was a problem hiding this comment.
Could we use a few more contexts with lower counts that are a bit more tightly coupled to the things that are deprecated ? Just want to make sure we aren't accidentally raising two deprecations on some fxn calls.
dstrain115
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
quantumlib#5424) - cirq.experiments.cross_entropy_benchmarking is redundant and not easy to adapt. - cirq.experiments.grid_parallel_two_qubit_xeb moved to recirq.benchmarks.xeb - Also delete cross_entropy_benchmarking example This is part of quantumlib#3775.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to adapt.
recirq.benchmarks.xeb
This is part of #3775.