Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a notebook describing parameter sweeps #5437

Merged
merged 5 commits into from
Jun 9, 2022

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Jun 2, 2022

No description provided.

@dabacon dabacon requested review from a team, vtomole and cduck as code owners June 2, 2022 20:40
@dabacon dabacon requested a review from viathor June 2, 2022 20:40
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jun 2, 2022
@dabacon dabacon requested a review from augustehirth June 2, 2022 22:59
@MichaelBroughton
Copy link
Collaborator

Looks good. Do we not have something already that explains the run_sweep, run_batch and run behaviors that we might be able to roll this into ? @augustehirth

@augustehirth
Copy link
Collaborator

We teach run_sweep in https://quantumai.google/cirq/simulation#parameterized_values_and_studies and https://quantumai.google/cirq/tutorials/basics#using_parameter_sweeps.

Run_batch is introduced in https://quantumai.google/cirq/google/engine#running_circuits_in_batch, which is an out-of-order QCS doc.

I think the detail presented in Dave's tutorial here is great and we would have to get rid of a lot of that if we were to merge it into somewhere else. This also gives us a place to write more functionality related to parameter sweeps if added in the future, like flattening was done recently.

However, I think the idea to have run behaviors in one place is a good idea, as long as it is applicable to all or most means of running/simulating (instead of just QCS). Do you think it would be suitable to add run_batch to this doc?

docs/params.ipynb Show resolved Hide resolved
docs/params.ipynb Show resolved Hide resolved
docs/params.ipynb Show resolved Hide resolved
docs/params.ipynb Show resolved Hide resolved
@dabacon dabacon requested a review from augustehirth June 8, 2022 23:33
@dabacon
Copy link
Collaborator Author

dabacon commented Jun 8, 2022

Updated per review comments, ready for re-review.

Copy link
Collaborator

@augustehirth augustehirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for all the updates

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 9, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 9, 2022
@CirqBot CirqBot merged commit be718a1 into quantumlib:master Jun 9, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants