-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a notebook describing parameter sweeps #5437
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Looks good. Do we not have something already that explains the run_sweep, run_batch and run behaviors that we might be able to roll this into ? @augustehirth |
We teach run_sweep in https://quantumai.google/cirq/simulation#parameterized_values_and_studies and https://quantumai.google/cirq/tutorials/basics#using_parameter_sweeps. Run_batch is introduced in https://quantumai.google/cirq/google/engine#running_circuits_in_batch, which is an out-of-order QCS doc. I think the detail presented in Dave's tutorial here is great and we would have to get rid of a lot of that if we were to merge it into somewhere else. This also gives us a place to write more functionality related to parameter sweeps if added in the future, like flattening was done recently. However, I think the idea to have run behaviors in one place is a good idea, as long as it is applicable to all or most means of running/simulating (instead of just QCS). Do you think it would be suitable to add |
Updated per review comments, ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for all the updates
No description provided.